Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to New Operator API Version #145

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Update to New Operator API Version #145

merged 5 commits into from
Jan 28, 2025

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Jan 23, 2025

  • Updates all languages to use v1beta1 API Version for the new operator changes.
  • Updates chart value setters to use controllerManager.manager.image.version instead of controllerManager.manager.image.tag
  • Add check to ensure test pods have initcontainer injected before running E2E tests.
  • Refactor Makefile scripting to be more clean.

@TimPansino TimPansino requested review from a team as code owners January 23, 2025 22:06
tippmar-nr
tippmar-nr previously approved these changes Jan 23, 2025
@TimPansino TimPansino force-pushed the fix-test-failures branch 2 times, most recently from 14848d4 to 9238d3e Compare January 24, 2025 00:45
Copy link

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fix https://github.com/newrelic/newrelic-agent-init-container/actions/runs/12938075032/job/36087424632 and allow our latest (12.11.2) image to be published?

@TimPansino
Copy link
Contributor Author

@jsumners-nr When we get this PR working, yes

@jsumners-nr
Copy link

@jsumners-nr When we get this PR working, yes

Cool. We have a patch release of Node.js that needs to go out to solve a customer issue and they are blocked on installing it because they rely on these images.

@TimPansino TimPansino force-pushed the fix-test-failures branch 2 times, most recently from a9f5a66 to 7422497 Compare January 28, 2025 00:51
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chasing this down!

tests/Makefile Show resolved Hide resolved
tests/java/test-specs.yml Show resolved Hide resolved
Copy link

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimPansino, thanks for putting this together! I have a few comments/questions about the changes.

Also, I'm not really familiar with Makefiles, so I apologize if some of these comments are really basic.

This was my first time running the Makefile on my machine. The script wouldn't complete if I just ran the all command. When I followed the steps in the README to run each step individually, it worked. After that point, if I ran all, it would work.

That might be a problem that predates this PR, but wanted to call it out JIC.

tests/Makefile Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
@TimPansino
Copy link
Contributor Author

@TimPansino, thanks for putting this together! I have a few comments/questions about the changes.

Also, I'm not really familiar with Makefiles, so I apologize if some of these comments are really basic.

This was my first time running the Makefile on my machine. The script wouldn't complete if I just ran the all command. When I followed the steps in the README to run each step individually, it worked. After that point, if I ran all, it would work.

That might be a problem that predates this PR, but wanted to call it out JIC.

Other people have had that problem too, I think it's just a timing thing. The minikube cluster or the operator might need more time to settle. Might adjust that later.

@tippmar-nr tippmar-nr requested a review from a team January 28, 2025 19:15
@iamemilio
Copy link

iamemilio commented Jan 28, 2025

I like the Makefile, that is a convention that is popular in the Kubernetes ecosystem and I am sure customers will like it. Since the Go team does not have an agent operator integration yet, don't let my comments hold you guys back.

I spent a lot of professional time managing resources in Kubernetes environments, so if you wanted an extra set of eyes I'm happy to help out from time to time.

@TimPansino TimPansino merged commit ea17827 into main Jan 28, 2025
49 checks passed
@TimPansino TimPansino deleted the fix-test-failures branch January 28, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants